Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Competition Submission API #18

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Admin Competition Submission API #18

wants to merge 4 commits into from

Conversation

jonnjonnjo
Copy link
Contributor

Features

  • Pagination based competition fetching

image
image

@fawwazabrials
Copy link
Contributor

Resolve conflict dulu bang @jonnjonnjo

@jonnjonnjo
Copy link
Contributor Author

Kayaknya ini butuh refaktor deh bil.

Pas buat team di postCreateTeamRoute, belom automatically create rows in competitionSubmission.
Aku mikirnya buat table lgi yg bisa store pair<competitionId, submissionType>
ntar di postCreateTeamRoute, ntar ambil dulu list dari submissionType dengan competitionId yang sesuai, terus baru for each submissionType, create rows in competitionSubmission. Sama atrribute media_id di competitionSubmission mending diubah jadi nullable semisal handle klo dia belum upload

atau mungkin bisa pake enum aja

@jonnjonnjo
Copy link
Contributor Author

ini udh bisa dimerge si wkwk @fawwazabrials itu beda isu si.

@fawwazabrials
Copy link
Contributor

sabar jon lahi mau buat workflow dulu wkwkw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fawwazabrials fawwazabrials Awaiting requested review from fawwazabrials

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnjonnjo @fawwazabrials