Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the no-std issue #669

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Fix the no-std issue #669

merged 2 commits into from
Aug 19, 2023

Conversation

weikengchen
Copy link
Member

Description

It appears that the lack of no-default-features of num-bigint in ark-ec has caused no-std tests to fail in the upstream.

This is not previously detected because the no-std test in ark-algebra is testing on a different arch than the one used in the upstream.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Re-reviewed Files changed in the GitHub PR explorer

N/A:

  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md

@weikengchen weikengchen requested review from a team as code owners August 19, 2023 18:43
@weikengchen weikengchen requested review from Pratyush and mmagician and removed request for a team August 19, 2023 18:43
@Pratyush Pratyush merged commit 66ca8ed into master Aug 19, 2023
7 of 15 checks passed
@Pratyush Pratyush deleted the fix-no-std branch August 19, 2023 18:52
aleasims pushed a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
@weikengchen @aleasims
Fix the no-std issue (arkworks-rs#669)
0adea8f
aleasims added a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
@aleasims
Revert "Fix the no-std issue (arkworks-rs#669)"
a71ece4 
This reverts commit 0adea8f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weikengchen @Pratyush