-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace inheritance #683
Workspace inheritance #683
Conversation
If we clone algebra inside curves, it will look at the curves Cargo.toml for workspace dependencies. Cloning it outside fixes this.
poly/Cargo.toml
Outdated
authors.workspace = true | ||
homepage.workspace = true | ||
repository.workspace = true | ||
keywords.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use per-crate keywords and categories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never had categories
, but I brought back the old keywords
: f01ed68
change dir to ark-algebra reference the right filepath in patching step
Does |
At least locally I can some correct display of equations, e.g. in That said, I remember there was a difference between local vs actual deployment of docs and how KaTeX was packaged there, so hard to say. I think we can later build a few alpha versions and see, these are handled just as proper releases are in terms of doc deployment, AFAIR. NB, including that
|
the copy-paste line for docs.rs was
but also curious to see if that |
The |
* Use workspace inheritance for dependencies * Fix CI: move algebra outside of curves dir If we clone algebra inside curves, it will look at the curves Cargo.toml for workspace dependencies. Cloning it outside fixes this. * Use workspace package for crate information * Try fix README * WIP * remove trailing space * update crate version numbers to 0.4.2 * bump Rust version * `algebra` path would overwrite the contents of the parent change dir to ark-algebra reference the right filepath in patching step * clone curves into a separate dir * update action versions * remove dir prints * revert keywords inheritance --------- Co-authored-by: William Arnold <will748@gmail.com> Co-authored-by: Weikeng Chen <w.k@berkeley.edu> Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
This reverts commit 820e48f.
Description
Based off #556. Weirdly "Maintainers are allowed to edit this pull request.", but: I can make edits to the original PR via the UI (e.g. resolve conflicts), yet not push directly.
@Pratyush I've removed the line you added in ff/lib.rs in b031934, I wasn't able to build with it.
closes: #556
This PR preserves the original commits and authorship.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
N/AFiles changed
in the GitHub PR explorer