Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1_XMD:SHA-256_SSWU_RO_ missing the isogenous generator #863

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skaunov
Copy link

@skaunov skaunov commented Nov 4, 2024

This PR is draft since I need a hint! When hashing the lib checks that the isogenous generator maps correctly onto the target curve generator. The problem is I couldn't find the relevant generator for RFC9380 yet (via a reference, or computationally). I found out that there's a path via the isogeny kernel, but I wonder if somebody could suggest a simpler way to obtain that to continue with this.

Description

Adds hashing to the <curves/secp256k1>.

closes: none - just a development


Since this isn't ready for merging yet it seems to me the check-list is ok to postpone, correct me if I'm wrong, pls.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@skaunov
Copy link
Author

skaunov commented Nov 4, 2024

@mmaker , I guess you've made most of this crate: could you take a look, pls. (Or tell who's the best person for this now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant