Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Absorb and update Cargo.toml #132

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

autquis
Copy link
Contributor

@autquis autquis commented Jan 23, 2024

With the current implementation of Poseidon, when trying to absorb a field element from a different field of sponge, there is no error and the developer would think everything is right :) The unwrap helps with making panics.

Also, I changed the repos from curves to algebra.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@autquis autquis requested a review from a team as a code owner January 23, 2024 00:29
@autquis autquis requested review from z-tech, Pratyush and weikengchen and removed request for a team January 23, 2024 00:29
@Pratyush Pratyush added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 23, 2024
@mmagician mmagician added this pull request to the merge queue Jan 23, 2024
@z-tech
Copy link

z-tech commented Jan 23, 2024

Sweet! Thx.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 23, 2024
@mmagician mmagician added this pull request to the merge queue Jan 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 23, 2024
@autquis
Copy link
Contributor Author

autquis commented Jan 23, 2024

What is happening to this merge queue? :D

@mmagician mmagician added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 25, 2024
@Pratyush Pratyush added this pull request to the merge queue Jan 25, 2024
@Pratyush Pratyush removed this pull request from the merge queue due to a manual request Jan 25, 2024
@Pratyush Pratyush added this pull request to the merge queue Jan 25, 2024
Merged via the queue into arkworks-rs:main with commit 9f9324b Jan 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants