Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the imports and merge them #143

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

autquis
Copy link
Contributor

@autquis autquis commented Apr 16, 2024

This PR sorts the imports by cargo fmt and merges them.
Also, I removed some places that were using core and replaced them with ark_std. Please check if it is correct.

By the way, there is pub(crate) use ark_std::vec::Vec in lib.rs. I don't understand why we still have to import it when it is no-std? @mmagician


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@autquis autquis requested a review from a team as a code owner April 16, 2024 14:39
@autquis autquis requested review from z-tech, Pratyush and weikengchen and removed request for a team April 16, 2024 14:39
@Pratyush
Copy link
Member

Sorry for the delay here, could you please rebase and then I can merge it!

@autquis
Copy link
Contributor Author

autquis commented Oct 21, 2024

Done! @Pratyush

@Pratyush Pratyush added this pull request to the merge queue Oct 21, 2024
Merged via the queue into arkworks-rs:main with commit 6d026d6 Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants