-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing example structure
from armadactl
#2551
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2551 +/- ##
=======================================
Coverage 58.57% 58.57%
=======================================
Files 236 236
Lines 29957 29957
=======================================
Hits 17548 17548
Misses 11062 11062
Partials 1347 1347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmd/armada-load-tester/cmd/root.go
Outdated
@@ -17,19 +17,6 @@ func init() { | |||
var rootCmd = &cobra.Command{ | |||
Use: "armada-load-tester command", | |||
Short: "Command line utility to submit many jobs to armada", | |||
Long: ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we remove the Long description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops thanks for noticing, I only wanted to remove the example structure
, let me correct that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And how does this interact with @zuqq PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zuqq has provided spaces and all in the same example structure
that I'm trying to remove, I also commented on his PR but didn't hear back from him. This deletion is not vital to the project its just that if you take a look at any other command-line tool eg: kubectl
you won't find any kind of structure, you only see what kubectl does and its commands so only for the purpose to make armadactl
look good I have proposed this change
Special notes for your reviewer:
This PR just removes the
example structure
from the armadactl┆Issue is synchronized with this Jira Task by Unito