Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy pod_issue_handler #2599

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Tidy pod_issue_handler #2599

merged 2 commits into from
Jun 22, 2023

Conversation

JamesMurkin
Copy link
Contributor

@JamesMurkin JamesMurkin commented Jun 22, 2023

This is largely a noop with a few minor changes

  • Move logging to happen before action is taken
  • Add logging for when issues self resolve
  • Don't break out of detectPodIssues - so we can detect more than 1 issue per round -

┆Issue is synchronized with this Jira Task by Unito

This is largely a noop with a few minor changes

 - Move logging to happen before action is taken
 - Add logging for when issues self resolve
 - Don't break out of detectPodIssues - so we can detect more than 1 issue per round
 -
@JamesMurkin JamesMurkin marked this pull request as ready for review June 22, 2023 09:55
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (3411e77) 58.57% compared to head (cbb35d5) 58.56%.

❗ Current head cbb35d5 differs from pull request most recent head 1fc0300. Consider uploading reports for the commit 1fc0300 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2599      +/-   ##
==========================================
- Coverage   58.57%   58.56%   -0.02%     
==========================================
  Files         236      236              
  Lines       30385    30380       -5     
==========================================
- Hits        17799    17791       -8     
- Misses      11219    11221       +2     
- Partials     1367     1368       +1     
Flag Coverage Δ
armada-server 58.56% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/executor/service/pod_issue_handler.go 75.43% <66.66%> (+0.33%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesMurkin JamesMurkin enabled auto-merge (squash) June 22, 2023 10:18
@JamesMurkin JamesMurkin merged commit 66ab364 into master Jun 22, 2023
25 checks passed
@JamesMurkin JamesMurkin deleted the tidy_issue_handler branch June 22, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants