Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new test workflow #2602

Merged
merged 25 commits into from
Jun 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
23b7ed1
add new test workflow
dejanzele Jun 22, 2023
9f6acce
fix integration test target
dejanzele Jun 22, 2023
ec1aebd
fix unit test filter
dejanzele Jun 22, 2023
c808cfa
exclude jobservice test
dejanzele Jun 22, 2023
b790921
Merge branch 'master' into feat/test-workflow
kannon92 Jun 23, 2023
60b75de
add lint workflow
dejanzele Jun 27, 2023
b6560b5
Merge branch 'master' into feat/test-workflow
dejanzele Jun 27, 2023
f46166a
Merge branch 'feat/test-workflow' of github.com:dejanzele/armada into…
dejanzele Jun 27, 2023
4d4082b
remove branches condition for test workflow on pr
dejanzele Jun 27, 2023
325580b
Merge branch 'master' into feat/test-workflow
dejanzele Jun 28, 2023
8984404
add aggregate workflow for CI
dejanzele Jun 28, 2023
a062acb
Merge branch 'feat/test-workflow' of github.com:dejanzele/armada into…
dejanzele Jun 28, 2023
be1ca4d
make test job after lint job
dejanzele Jun 28, 2023
0ef06c0
add codeql job to ci
dejanzele Jun 28, 2023
7ff9ec3
fix permissions in ci workflow
dejanzele Jun 28, 2023
4535fc7
make codeql job run after lint job
dejanzele Jun 28, 2023
5fb890f
remove needs from ci workflow jobs
dejanzele Jun 28, 2023
397b126
run job on ubuntu 22.04
dejanzele Jun 28, 2023
dcea1da
move ts workflows to ci workflow
dejanzele Jun 28, 2023
9278fdf
rename jobs in ci workflow
dejanzele Jun 28, 2023
18c2e31
remove obsolete workflows
dejanzele Jun 28, 2023
1050e31
add junit report for ts tests
dejanzele Jun 28, 2023
ae97e4a
Merge branch 'master' into feat/test-workflow
dejanzele Jun 28, 2023
38ed669
Merge branch 'master' into feat/test-workflow
dejanzele Jun 29, 2023
ddd5aeb
Merge branch 'master' into feat/test-workflow
dejanzele Jun 29, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: CI

on:
push:
branches-ignore:
- gh-pages
pull_request:
branches-ignore:
- gh-pages
schedule:
# Run daily at 01:34, so we get notified if CI is broken before a pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this exact time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, random

# is submitted.
- cron: "34 1 * * *"

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read
pull-requests: read
checks: write
actions: read
security-events: write

jobs:
lint:
uses: ./.github/workflows/lint.yml
codeql:
uses: ./.github/workflows/codeql-analysis.yml
test:
uses: ./.github/workflows/test.yml
# Virtual job that can be configured as a required check before a PR can be merged.
all-required-checks-done:
name: All required checks done
needs:
- lint
- codeql
- test
runs-on: ubuntu-22.04
steps:
- run: |
echo "All required checks done"

12 changes: 5 additions & 7 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,11 @@
name: "CodeQL"

on:
push:
branches: [ master ]
pull_request:
# The branches below must be a subset of the branches above
branches: [ master ]
schedule:
- cron: '15 2 * * 4'
workflow_call:

permissions:
actions: read
security-events: write

jobs:
analyze:
Expand Down
26 changes: 0 additions & 26 deletions .github/workflows/coverage.yml

This file was deleted.

73 changes: 0 additions & 73 deletions .github/workflows/go-integration.yml

This file was deleted.

66 changes: 0 additions & 66 deletions .github/workflows/go.yml

This file was deleted.

53 changes: 53 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
name: "Lint"

on:
workflow_call:

permissions:
contents: read
pull-requests: read

jobs:
ts-lint:
# TODO(JayF): Determine what nodejs versions we target, and setup matrix-based testing similar to what we do for go
name: Lint TypeScript
runs-on: ubuntu-22.04

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 16.14.2
cache: yarn
cache-dependency-path: ./internal/lookout/ui/yarn.lock

- name: Check TypeScript formatting
run: |
yarn install --frozen-lockfile && yarn run fmt || exit 1
exit $(git status -s -uno | wc -l)
working-directory: ./internal/lookout/ui

go-lint:
name: Lint Go
runs-on: ubuntu-22.04

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Golang with Cache
uses: magnetikonline/action-golang-cache@v4
with:
go-version: "1.20"

- name: Lint using golangci-lint
uses: golangci/golangci-lint-action@v3
with:
skip-pkg-cache: true
skip-build-cache: true
version: v1.52.2
only-new-issues: true
args: --timeout=10m --issues-exit-code=1 --sort-results ./...
27 changes: 0 additions & 27 deletions .github/workflows/not-ts.yml

This file was deleted.

Loading
Loading