Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(update): Added Job summary for lint.yml workflow #2755

Closed
wants to merge 7 commits into from
Closed

Feat(update): Added Job summary for lint.yml workflow #2755

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62353c1
Feat(update): Added Job summary for lint.yml workflow
itsaviral2609 Jul 26, 2023
e63fba3
Feat(update): Added Job summary for lint.yml workflow
itsaviral2609 Jul 26, 2023
22b0a3a
Feat(update): Testing and adding scenarios 1 and 2
itsaviral2609 Jul 26, 2023
37ead48
Feat(update): Testing and adding scenarios for golangci-lint
itsaviral2609 Jul 26, 2023
5f4ceba
Feat(update): Testing and adding scenarios for golangci-lint
itsaviral2609 Jul 26, 2023
06f00b2
squashing failed commits
itsaviral2609 Jul 29, 2023
c871f13
Merge branch 'armadaproject:master' into itsaviral-lint.yml
itsaviral2609 Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,40 +14,59 @@ jobs:
runs-on: ubuntu-22.04

steps:
- name: Checkout
- name: Adding markdown
run: echo '### Lint TypeScript ✨' >> $GITHUB_STEP_SUMMARY

- name: Checkout
uses: actions/checkout@v3.3.0

- name: Setup Node
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 16.14.2
cache: yarn
cache-dependency-path: ./internal/lookout/ui/yarn.lock

- name: Check TypeScript formatting
- name: Check TypeScript formatting
run: |
yarn install --frozen-lockfile && yarn run fmt || exit 1
exit $(git status -s -uno | wc -l)
working-directory: ./internal/lookout/ui

- name: Generate list using Markdown
run: |
echo "- ✔️ Checked out the repository" >> $GITHUB_STEP_SUMMARY
echo "- ✔️ Set up Node.js with version 16.14.2 and cached Yarn dependencies" >> $GITHUB_STEP_SUMMARY
echo "- ✔️ Checked TypeScript formatting" >> $GITHUB_STEP_SUMMARY

go-lint:
name: Lint Go
runs-on: ubuntu-22.04

steps:
- name: Checkout
- name: Adding markdown
run: echo '### Lint Go ✨' >> $GITHUB_STEP_SUMMARY

- name: Checkout
uses: actions/checkout@v3.3.0

- name: Setup Golang with Cache
- name: Setup Golang with Cache
uses: magnetikonline/action-golang-cache@v4
with:
go-version: "1.20"

- name: Lint using golangci-lint
- name: Lint using golangci-lint
uses: golangci/golangci-lint-action@v3
with:
skip-pkg-cache: true
skip-build-cache: true
version: v1.52.2
only-new-issues: true
args: --timeout=10m --issues-exit-code=1 --sort-results ./...

- name: Generate list using Markdown
run: |
echo "- ✔️ Checked out the repository" >> $GITHUB_STEP_SUMMARY
echo "- ✔️ Set up Go with version 1.20 and cached dependencies" >> $GITHUB_STEP_SUMMARY
echo "- ✔️ Linted Go code using golangci-lint" >> $GITHUB_STEP_SUMMARY

Loading