Magefile: Clean all Makefile refernces #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mo-Fatah
force-pushed
the
mage-changes
branch
2 times, most recently
from
52d4c0b
to
829a170
Compare
Mo-Fatah
changed the title
Mo-Fatah
commented
Sep 8, 2023
| @@ -63,7 +63,7 @@ func LintFix() error { | |||
| } | |||
|
|
|||
| // Linting Check | |||
| func CheckLint() error { | |||
| func LintCheck() error { | |||
There was a problem hiding this comment.
just to be consistent with LintFix
|
You will need to rebuild the python client docs and airflow docs if you make changes to them.
|
Mo-Fatah
force-pushed
the
mage-changes
branch
from
829a170
to
7ad2685
Compare
Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com>
Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com>
Mo-Fatah
force-pushed
the
mage-changes
branch
from
7ad2685
to
e1d3a33
Compare
Sharpz7
approved these changes
Sep 12, 2023
svc-gh-ghzonetrans-p
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Wire up minimum gang cardinality * Wire up minimum gang cardinality * Wire up minimum gang cardinality * Wire up minimum gang cardinality * Bump armada airflow operator to version 0.5.4 (#2961) * Bump armada airflow operator to version 0.5.4 Signed-off-by: Rich Scott <richscott@sent.com> * Regenerate Airflow Operator Markdown doc. Signed-off-by: Rich Scott <richscott@sent.com> * Fix regenerated Airflow doc error. Signed-off-by: Rich Scott <richscott@sent.com> * Pin versions of all modules, especially around docs generation. Signed-off-by: Rich Scott <richscott@sent.com> * Regenerate Airflow docs using Python 3.10 Signed-off-by: Rich Scott <richscott@sent.com> --------- Signed-off-by: Rich Scott <richscott@sent.com> * Infer failed jobs from job context, tidy up * Infer failed jobs from job context, tidy up * Magefile: Clean all Makefile refernces (#2957) * tiny naming change * clean all make refernces Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> --------- Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> * Infer failed jobs from job context, tidy up * Revert to previous unpinned airflow version spec. (#2967) * Revert to previous unpinned airflow version spec. Signed-off-by: Rich Scott <richscott@sent.com> * Increment armada-airflow module version. Signed-off-by: Rich Scott <richscott@sent.com> --------- Signed-off-by: Rich Scott <richscott@sent.com> * Only fail gang jobs when the overall gang min cardinality is set. Fix error handling * Only fail gang jobs when the overall gang min cardinality is set. Fix error handling * Only fail gang jobs when the overall gang min cardinality is set. Fix error handling * Update jobdb with any excess gang jobs that failed * ArmadaContext.Log Improvements (#2965) * log error * context log * context log * add cycle id * typo * lint * refactor armadacontext to implement a FieldLogger --------- Co-authored-by: Chris Martin <chris@cmartinit.co.uk> * Fix-up existing tests before adding new ones * Add new tests for minimum gang sizes * Test that excess failed gang jobs are committed to jobdb * Run `on.push` only for master (#2968) * Run On Push only for master Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> * remove not-workflows Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> --------- Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> * Add test for failed job pulsar messages * Tidy tests * WIP: Airflow: fix undefined poll_interval in Deferrable Operator (#2975) * Airflow: handle poll_interval attr in ArmadaJobCompleteTrigger Fix incomplete handling of 'poll_interval' attribute in ArmadaJobCompleteTrigger, used by the Armada Deferrable Operator for Airflow. Signed-off-by: Rich Scott <richscott@sent.com> * Airflow - add unit test for armada deferrable operator Run much of the same tests for the deferrable operator as for the regular operator, plus test serialization. Also, update interval signifier in examples. A full test of the deferrable operator that verifies the trigger handling is still needed. Signed-off-by: Rich Scott <richscott@sent.com> --------- Signed-off-by: Rich Scott <richscott@sent.com> * Release Airflow Operator v0.5.6 (#2979) Signed-off-by: Rich Scott <richscott@sent.com> * #2905 - fix indentation (#2971) Co-authored-by: Mohamed Abdelfatah <39927413+Mo-Fatah@users.noreply.github.com> Co-authored-by: Adam McArthur <46480158+Sharpz7@users.noreply.github.com> Signed-off-by: Rich Scott <richscott@sent.com> Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> Co-authored-by: Rich Scott <rich@gr-oss.io> Co-authored-by: Mohamed Abdelfatah <39927413+Mo-Fatah@users.noreply.github.com> Co-authored-by: Chris Martin <council_tax@hotmail.com> Co-authored-by: Chris Martin <chris@cmartinit.co.uk> Co-authored-by: Dave Gantenbein <dave@gr-oss.io> Co-authored-by: Adam McArthur <46480158+Sharpz7@users.noreply.github.com>
severinson
added a commit
that referenced
this pull request
Oct 9, 2023
* Wire in min cardinality (#8) * Wire up minimum gang cardinality * Wire up minimum gang cardinality * Wire up minimum gang cardinality * Wire up minimum gang cardinality * Bump armada airflow operator to version 0.5.4 (#2961) * Bump armada airflow operator to version 0.5.4 Signed-off-by: Rich Scott <richscott@sent.com> * Regenerate Airflow Operator Markdown doc. Signed-off-by: Rich Scott <richscott@sent.com> * Fix regenerated Airflow doc error. Signed-off-by: Rich Scott <richscott@sent.com> * Pin versions of all modules, especially around docs generation. Signed-off-by: Rich Scott <richscott@sent.com> * Regenerate Airflow docs using Python 3.10 Signed-off-by: Rich Scott <richscott@sent.com> --------- Signed-off-by: Rich Scott <richscott@sent.com> * Infer failed jobs from job context, tidy up * Infer failed jobs from job context, tidy up * Magefile: Clean all Makefile refernces (#2957) * tiny naming change * clean all make refernces Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> --------- Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> * Infer failed jobs from job context, tidy up * Revert to previous unpinned airflow version spec. (#2967) * Revert to previous unpinned airflow version spec. Signed-off-by: Rich Scott <richscott@sent.com> * Increment armada-airflow module version. Signed-off-by: Rich Scott <richscott@sent.com> --------- Signed-off-by: Rich Scott <richscott@sent.com> * Only fail gang jobs when the overall gang min cardinality is set. Fix error handling * Only fail gang jobs when the overall gang min cardinality is set. Fix error handling * Only fail gang jobs when the overall gang min cardinality is set. Fix error handling * Update jobdb with any excess gang jobs that failed * ArmadaContext.Log Improvements (#2965) * log error * context log * context log * add cycle id * typo * lint * refactor armadacontext to implement a FieldLogger --------- Co-authored-by: Chris Martin <chris@cmartinit.co.uk> * Fix-up existing tests before adding new ones * Add new tests for minimum gang sizes * Test that excess failed gang jobs are committed to jobdb * Run `on.push` only for master (#2968) * Run On Push only for master Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> * remove not-workflows Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> --------- Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> * Add test for failed job pulsar messages * Tidy tests * WIP: Airflow: fix undefined poll_interval in Deferrable Operator (#2975) * Airflow: handle poll_interval attr in ArmadaJobCompleteTrigger Fix incomplete handling of 'poll_interval' attribute in ArmadaJobCompleteTrigger, used by the Armada Deferrable Operator for Airflow. Signed-off-by: Rich Scott <richscott@sent.com> * Airflow - add unit test for armada deferrable operator Run much of the same tests for the deferrable operator as for the regular operator, plus test serialization. Also, update interval signifier in examples. A full test of the deferrable operator that verifies the trigger handling is still needed. Signed-off-by: Rich Scott <richscott@sent.com> --------- Signed-off-by: Rich Scott <richscott@sent.com> * Release Airflow Operator v0.5.6 (#2979) Signed-off-by: Rich Scott <richscott@sent.com> * #2905 - fix indentation (#2971) Co-authored-by: Mohamed Abdelfatah <39927413+Mo-Fatah@users.noreply.github.com> Co-authored-by: Adam McArthur <46480158+Sharpz7@users.noreply.github.com> Signed-off-by: Rich Scott <richscott@sent.com> Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> Co-authored-by: Rich Scott <rich@gr-oss.io> Co-authored-by: Mohamed Abdelfatah <39927413+Mo-Fatah@users.noreply.github.com> Co-authored-by: Chris Martin <council_tax@hotmail.com> Co-authored-by: Chris Martin <chris@cmartinit.co.uk> Co-authored-by: Dave Gantenbein <dave@gr-oss.io> Co-authored-by: Adam McArthur <46480158+Sharpz7@users.noreply.github.com> * Remove unintentional diffs * Run formatting tools * Fix formatting * Re-run proto gen + dotnet gen * Validate gang min cardinality is <= gang cardinality * mage proto * Tidying --------- Signed-off-by: Rich Scott <richscott@sent.com> Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com> Co-authored-by: Mark Sumner <Mark.Sumner@gresearch.co.uk> Co-authored-by: Rich Scott <rich@gr-oss.io> Co-authored-by: Mohamed Abdelfatah <39927413+Mo-Fatah@users.noreply.github.com> Co-authored-by: Chris Martin <council_tax@hotmail.com> Co-authored-by: Chris Martin <chris@cmartinit.co.uk> Co-authored-by: Dave Gantenbein <dave@gr-oss.io> Co-authored-by: Adam McArthur <46480158+Sharpz7@users.noreply.github.com> Co-authored-by: Albin Severinson <albin@severinson.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.