Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated WIREGUARD once and for all #7452

Merged
merged 9 commits into from
Nov 9, 2024
Merged

Conversation

EvilOlaf
Copy link
Member

@EvilOlaf EvilOlaf commented Nov 8, 2024

Description

Addresses #7282

tl;dr: Wireguard is present by default everywhere.

Those board configs where WIREGUARD disable switch has been removed may need to be tested for regressions.

GitHub issue reference:
Jira reference number [AR-9999]

How Has This Been Tested?

  • No tests (yet)

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels Nov 8, 2024
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Also remove this switch from documentation. I believe its already in the deprecated section, but that is copy/paste source. And you might find a type somewhere around ;)

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Nov 8, 2024

Yeah already in deprecated section, so not that important.

igorpecovnik added a commit to armbian/documentation that referenced this pull request Nov 9, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release and removed Needs review Seeking for review labels Nov 9, 2024
@igorpecovnik igorpecovnik merged commit 0afd94a into armbian:main Nov 9, 2024
12 checks passed
igorpecovnik added a commit to armbian/documentation that referenced this pull request Nov 9, 2024
@EvilOlaf EvilOlaf deleted the wg branch November 10, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants