Parse Rust toolchain file with a real script #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate the code which parses the rust-toolchain.toml file from inline YAML in the nightly GitHub Actions workflow to a standalone Python script. - Converted the command previously defined in inline YAML with `python` shell to a dedicated Python script. - Added an `Args` dataclass and `OutputFormat` enum for structured argument parsing. - Implemented `read_toolchain_version` function with robust error handling for malformed TOML files. - Integrated GitHub Actions helpers for environment-specific logging and output formatting. - Added `--format` flag to support plaintext and GitHub Actions-specific outputs, improving flexibility. - Modified `log_group` helper to output only when running within GitHub Actions. - Ensured error messages are printed to stderr for better debugging visibility.
lopopolo
added
A-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the code which parses the rust-toolchain.toml file from inline YAML in the nightly GitHub Actions workflow to a standalone Python script.
pythonshell to a dedicated Python script.Argsdataclass andOutputFormatenum for structured argument parsing.read_toolchain_versionfunction with robust error handling for malformed TOML files.--formatflag to support plaintext and GitHub Actions-specific outputs, improving flexibility.log_grouphelper to output only when running within GitHub Actions.