Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to use node 20 #399

Merged
merged 4 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"name": "Node.js & TypeScript",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/typescript-node:0-18",
"image": "mcr.microsoft.com/devcontainers/typescript-node:0-20",
"features": {
"ghcr.io/devcontainers/features/common-utils:2": {
"installOhMyZsh": true,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [pull_request]

env:
RUNNER_TEMP: /tmp
TEST_ARTIFACT_VERSION: 0.9.1
TEST_ARTIFACT_VERSION: 0.10.0

jobs:
local_tests:
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
FROM node:18-slim AS builder
FROM node:20-slim AS builder

WORKDIR /app
COPY package*.json ./
RUN npm ci
COPY . ./
RUN npm run build

FROM node:18-slim AS runner
FROM node:20-slim AS runner

# Required for python inside Docker containers
ENV LC_ALL C.UTF-8
Expand All @@ -22,12 +22,12 @@ RUN apt-get update \
&& rm -rf /var/lib/apt/lists/*

RUN npm install -g npm \
&& python3 -m pip install --no-cache-dir --upgrade pip
&& python3 -m pip install --no-cache-dir --upgrade --break-system-packages pip

WORKDIR /app

COPY requirements.txt ./
RUN python3 -m pip install --no-cache-dir -r requirements.txt
RUN python3 -m pip install --no-cache-dir --break-system-packages -r requirements.txt

COPY --from=builder /app/dist ./dist
COPY package*.json ./
Expand Down
2 changes: 1 addition & 1 deletion fake_collection/galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace: artis3n
name: test_resource_do_not_use
version: 2.9.1
version: 2.10.0
readme: README.md
authors:
- Ari Kalfus (@artis3n) <dev@artis3nal.com>
Expand Down
Loading