Upgrade ANTLR to 4.13.1 #633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the benefit of doing this update? |
|
In the project I am currently working on, we have implemented a Domain Specific Language using ANTLR4 and Antlr4BuildTasks. This requires us to use ANTLR 4.13.1, which is incompatible with the ANTLR 4.8.0 version currently used by AngouriMath, causing issues in our existing code powered by AngouriMath. To ensure compatibility with other projects using ANTLR, we kindly request that you consider upgrading to ANTLR 4.13.1 as well. |
|
Sorry, but I guess you will have to maintain your own version. I haven't had time to maintain this project lately, the CI doesn't even work anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filepath changes in
antlr_rerun.batandAntlrPostProcessor.cswere made based on runningantlr_rerun.batfrom PROJECT_ROOT\Sources\AngouriMath\AngouriMath.I am not sure if I was supposed to change that and I am also not sure if this is the right place to run the script from.