-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making the labels in the sidebar usable as search filters #198
Conversation
PR Summary
|
Hey @philipsorensen! You're absolutely right about expecting the labels to work as buttons. It's something that I've wanted to add since I first built Find A PR, but I kept forgetting haha! So I'm definitely all for this addition 😄 I'll check out this PR now and see if we can get it merged today 😎 |
Just from having a quick browse through this, it looks great! I do have an idea for a possible improvement though if you're interested in an extra contribution? I think it'd be really cool to display the number of issues that each label on the label itself. For example, the list of labels on the left hand side could be:
What's your opinion on adding something like that? And it's totally cool if you'd prefer not to add it by the way 😄 |
Great idea with the numbers. I'm looking into it. 😎 |
# Conflicts: # resources/views/components/side-bar.blade.php
Huge thank you again for this PR, @philipsorensen! I'm really sorry it took so long to get merged in (life has been so busy!). Your changes should be deploying to production now 😄 |
I was really surprised the labels in the sidebar did nothing, so I made them usable as search filters that can be toggled. If an issue has any of the enabled labels it is shown. There's a couple of different ways, you could do this, but I think this is the most straightforward.
Also a slight update of the readme.