Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the labels in the sidebar usable as search filters #198

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

philipsorensen
Copy link
Contributor

I was really surprised the labels in the sidebar did nothing, so I made them usable as search filters that can be toggled. If an issue has any of the enabled labels it is shown. There's a couple of different ways, you could do this, but I think this is the most straightforward.

Also a slight update of the readme.

Copy link

what-the-diff bot commented May 1, 2024

PR Summary

  • PHP Version Update in README
    The minimum PHP version requirement was updated to 8.2 in the README file. This change means that our project now requires PHP 8.2 to function properly.

  • Enhancements in ListIssues.php

    • Added an option to filter issues based on certain labels with the addition of $searchLabels.
    • Updated the render method to apply this new label filtering functionality.
    • A new function toggleSearchLabel has been introduced to alternate between active and inactive states of the search label.
  • Styling updates in side-bar.blade.php

    • The appearance of the buttons used for search labels has been updated to make the labels more noticeable to users. This small aesthetic change will help users to distinguish and work with search labels more effectively.

@ash-jc-allen
Copy link
Owner

Hey @philipsorensen! You're absolutely right about expecting the labels to work as buttons. It's something that I've wanted to add since I first built Find A PR, but I kept forgetting haha! So I'm definitely all for this addition 😄

I'll check out this PR now and see if we can get it merged today 😎

@ash-jc-allen
Copy link
Owner

Just from having a quick browse through this, it looks great! I do have an idea for a possible improvement though if you're interested in an extra contribution?

I think it'd be really cool to display the number of issues that each label on the label itself. For example, the list of labels on the left hand side could be:

  • findapr (3)
  • first good issue (0)
  • first issue (10)
  • first pr (100)
  • help wanted (20)

What's your opinion on adding something like that? And it's totally cool if you'd prefer not to add it by the way 😄

@philipsorensen
Copy link
Contributor Author

Great idea with the numbers. I'm looking into it. 😎

@ash-jc-allen ash-jc-allen merged commit 366b248 into ash-jc-allen:master Aug 21, 2024
3 checks passed
@ash-jc-allen
Copy link
Owner

Huge thank you again for this PR, @philipsorensen! I'm really sorry it took so long to get merged in (life has been so busy!). Your changes should be deploying to production now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants