Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request follow-up for #30: Take care of undefined globals warning #40

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

mcaceresb
Copy link
Collaborator

Addresses this comment.

  • Moved to referencing variables in dplyr calls through .data; I believe this is the correct method.
  • Declared foreach looping variable to NULL at top of each relevant function; this is a workaround but seems to work fine to avoid the note.

devtools::check() passes without any notes, warnings, or errors. @asheshrambachan

@mcaceresb mcaceresb mentioned this pull request Aug 21, 2023
@asheshrambachan asheshrambachan merged commit bb2c7b6 into asheshrambachan:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants