Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env var PRISMLAUNCHER_DATA_DIR #7

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

thatLeaflet
Copy link
Contributor

@thatLeaflet thatLeaflet commented Oct 24, 2024

This tells PrismLauncher to put its data in a subdir of $SNAP_USER_COMMON rather than directly in $SNAP_USER_COMMON.

This will not migrate existing user data, but seeing as this snap is still on the edge branch, this should not matter.

Edit: To clarify, this env var was introduced in 9.0, so it will not do anything in 8.4.

This tells PrismLauncher to put its data in a subdir of $SNAP_USER_COMMON rather than directly in $SNAP_USER_COMMON.
@ashuntu
Copy link
Owner

ashuntu commented Oct 24, 2024

I'm not sure I see the benefit in nesting configuration data one layer lower. Are there conflicts you are running into at the moment with how it works now? $SNAP_USER_COMMON is for persistent app data, so I'm not sure what the problem is.

@thatLeaflet
Copy link
Contributor Author

Personally, I think it's messy to have PrismLauncher put all its files directly into SNAP_USER_COMMON because that directory also contains your .cache, .config, etc. In theory, PrismLauncher could have a name collision with those.

This brings the snap in line with the other distribution methods which store their files in a subdir called "PrismLauncher", whether in ~/.local/PrismLauncher or ~/.var/app/org.prismlauncher.PrismLauncher/data/PrismLauncher.

@ashuntu
Copy link
Owner

ashuntu commented Oct 24, 2024

Ok, that's fine, just wanted to make sure there wasn't an issue I didn't know about.

@ashuntu ashuntu merged commit fb137d4 into ashuntu:main Oct 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants