Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartPad with 0 #5

Closed
wants to merge 1 commit into from
Closed

Conversation

Crow2525-pp
Copy link

Added '0' padding to 2, 3, and 4 digs ANZSIC and Num Col to Division Alpha to address issue 3 & 4.

Added '0' padding to 2, 3, and 4 digs ANZSIC and Num Col to Division Alpha
@asiripanich
Copy link
Owner

Hi @Crow2525-pp, thank you for the PR.

May I get your opinion on whether we should treat those number columns as numeric or character? The reason I'm asking is because all the values in those columns are numeric. Is it better to leave them as they are?

@williamlai2 would this PR affect your code? specifically https://github.com/runapp-aus/strayr?

@williamlai2
Copy link
Contributor

Looking at https://github.com/runapp-aus/strayr/blob/master/data-raw/create_anzsic2006.R this change would break the code because anzsic_class_code and other bits rely on the group_code in the original file being a double that gets converted to an integer, whereas with the padded 0, they would be strings. This could all be fixed though.

@daviddiviny wrote the original code for this.

It is slightly related to issues in runapp-aus/strayr#91 as well. A workaround could be having a different source for the ANZSIC codes too.

@daviddivinynous
Copy link

Yes, this is worth fixing I think.

@asiripanich
Copy link
Owner

Fixed in #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants