Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move npm_registry_url to utils #1758

Merged
merged 1 commit into from
May 28, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented May 27, 2024

I'm not sure why I missed this, but it looks like this path is not tested on CI until merging to main? See https://github.com/aspect-build/rules_js/actions/runs/9248267733/job/25438315100

Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:

@jbedard jbedard requested a review from gregmagolan May 27, 2024 03:38
Copy link

aspect-workflows bot commented May 27, 2024

Test

All tests were cache hits

191 tests (100.0%) were fully cached saving 52s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 923ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 520ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

21 tests (100.0%) were fully cached saving 7s.


Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 605ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.


Buildifier      Format

@jbedard jbedard force-pushed the testutils-fix branch 2 times, most recently from 6b55f33 to 2c92216 Compare May 27, 2024 22:13
@jbedard jbedard force-pushed the testutils-fix branch 2 times, most recently from 15ae48a to 3101d39 Compare May 27, 2024 22:28
@jbedard jbedard merged commit 31118a6 into aspect-build:main May 28, 2024
98 checks passed
@jbedard jbedard deleted the testutils-fix branch May 28, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants