Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): support pnpm v9.7+ patches without version specifier #2059

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 7, 2025

Fix #2031


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

PNPM v9.7+ supports pnpm.patchedDependencies specifiers with no version specified.

Test plan

  • New test cases added

Copy link

aspect-workflows bot commented Jan 7, 2025

Test

All tests were cache hits

212 tests (100.0%) were fully cached saving 37s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 172ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 555ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 575ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 97ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 162ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 93ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 362ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 4s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 1s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 276ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 115ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 116ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 181ms.


Buildifier      Format

@jbedard jbedard force-pushed the 2031-versionless-patches branch from b787c7d to 0dbb5a3 Compare January 9, 2025 19:47
@jbedard jbedard enabled auto-merge (squash) January 9, 2025 19:49
@jbedard jbedard force-pushed the 2031-versionless-patches branch from 0dbb5a3 to c667c98 Compare January 9, 2025 20:16
@jbedard jbedard merged commit d9e38a4 into aspect-build:main Jan 10, 2025
96 checks passed
@jbedard jbedard deleted the 2031-versionless-patches branch January 10, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Rules JS misses version-less patches that pnpm itself can apply
2 participants