Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add comments/docs for pnpm lockfile fields #2060

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 8, 2025

To clarify differences between lockfiles as well as differences between lockfiles and this struct which is normalized across lockfile versions as much as possible.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Jan 8, 2025

Test

All tests were cache hits

212 tests (100.0%) were fully cached saving 37s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 172ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 555ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 575ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 97ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 145ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 93ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 362ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 4s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 1s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 276ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 115ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 116ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 181ms.


Buildifier      Format

npm/private/pnpm.bzl Outdated Show resolved Hide resolved
npm/private/pnpm.bzl Outdated Show resolved Hide resolved
@jbedard jbedard enabled auto-merge (squash) January 12, 2025 04:52
@jbedard jbedard merged commit fd4ef5a into aspect-build:main Jan 12, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants