Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: calculate js_outs once outside srcs loop #229

Merged
merged 1 commit into from
Feb 8, 2024
Merged

perf: calculate js_outs once outside srcs loop #229

merged 1 commit into from
Feb 8, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Feb 8, 2024

Type of change

  • Performance (a code change that improves performance)

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from gregmagolan February 8, 2024 04:22
gregmagolan
gregmagolan approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

@jbedard jbedard merged commit 6bf6610 into main Feb 8, 2024
10 checks passed
@jbedard jbedard deleted the analysis-perf branch February 8, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @gregmagolan