Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring package_prefix is correct for external workspaces #726

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Ensuring package_prefix is correct for external workspaces #726

merged 4 commits into from
Oct 28, 2024

Conversation

menny
Copy link
Contributor

@menny menny commented Oct 28, 2024 •
edited
Loading

This is a fix over the changes in #687.

Test plan

New unit-tests

  • Covered by existing test cases: partial
  • New test cases added: added under e2e folder.
  • Manual testing; please provide instructions so we can reproduce:
    • Add a TS repo as an external repository. This should have a target that:
      • is a ts_project
      • inside a subfolder
      • has tsconfig attribute set to a dict.
    • build the ts_project target inside this external repository

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@menny menny force-pushed the fix-tsconfig-package-prefix-for-nested-workspaces branch from 12cdbed to f445c9a Compare October 28, 2024 17:32
@jbedard
Copy link
Member

jbedard commented Oct 28, 2024

If we can just get a test reproducing it that would be great 👍

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Oct 28, 2024 •
edited
Loading

Test

All tests were cache hits

142 tests (100.0%) were fully cached saving 8s.

Buildifier      Format

@menny menny force-pushed the fix-tsconfig-package-prefix-for-nested-workspaces branch 4 times, most recently from 8bc63ee to 7fa1d94 Compare October 28, 2024 20:24
@menny menny marked this pull request as ready for review October 28, 2024 20:31
@menny menny force-pushed the fix-tsconfig-package-prefix-for-nested-workspaces branch from 7fa1d94 to 75fc148 Compare October 28, 2024 20:38
@jbedard jbedard enabled auto-merge (squash) October 28, 2024 20:40
@jbedard jbedard disabled auto-merge October 28, 2024 21:09
@jbedard jbedard merged commit 6df0fe6 into aspect-build:main Oct 28, 2024
24 checks passed
@menny menny deleted the fix-tsconfig-package-prefix-for-nested-workspaces branch October 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@menny @CLAassistant @jbedard