fix: Edge case where ts_proto_library depends on proto_library(strip_import_prefix=...)

[amari]

This PR fixes #476, an edge case where a ts_proto_library depends on a proto_library(strip_import_prefix=...).

For example, the file proto/myorg/routeguide/v1/route.proto:

• can be declared via myorg.routeguide.v1 instead of proto.myorg.routeguide.v1, and
• can be imported using the path myorg/routeguide/v1/route.proto instead of proto/routeguide/v1/route.proto

Previously, ts_proto_library was not providing a complete set of imports to protoc.

After fixing the import problem, building failed b/c .d.ts and .js files were being written to the wrong location.

I needed helper functions from @protobuf//bazel/common:proto_common.bzl, but since this repository still depends on the deprecated @rules_protobuf, I just copied them.

However, they're governed by Google's BSD-like license. I would like to refactor it into a "third-party" directory, but none exists and I saw no documentation/guidelines about how to go about it. I also plan on adding an example after getting feedback on this.

---

Changes are visible to end-users: yes

• Searched for relevant documentation and updated as needed: no
• Breaking change (forces users to change their own code or config): no
• Suggested release notes appear below: yes

Fixes edge case where ts_proto_library depends on proto_library(strip_import_prefix=...)

Test plan

• TODO: will include test after I get feedback on whether a "third-party" directory is even necessary vs attribution.

For now, I've removed the test-case.

[CLAassistant]

All committers have signed the CLA.

[aspect-workflows]

Test

3 test targets passed

Targets

//examples/proto_grpc:main [k8-fastbuild]                        201ms
//examples/proto_grpc:status_ts_proto.copy_0_test [k8-fastbuild] 55ms
//examples/proto_grpc:status_ts_proto.copy_1_test [k8-fastbuild] 52ms

Total test execution time was 308ms. 160 tests (98.2%) were fully cached saving 15s.

---

Buildifier      Format

[amari]

I ran into these same testing failures locally.

They were resolved by running: bazel run //examples/proto_grpc:status_ts_proto.copy_1 and bazel run //examples/proto_grpc:status_ts_proto.copy_0.

I didn't include them in the PR b/c the changes seemed out of scope.

EDIT:

The tests failed b/c previously the comments from examples/proto_grpc/status.proto were not copied over by protoc to examples/proto_grpc/status_pb.d.ts and examples/proto_grpc/status_connect.d.ts.

I've added the generated .d.ts files to the PR.

[amari]

@kormide @jbedard @alexeagle

[amari]

@jbedard