Adapt to Cdnjs API changes #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cdnjs API is changing to stop including the assets for all versions of a library in the /libraries/:library API. We were using this to determine both library versions and library files. The changes are fairly straightforward: - for versions, we can just use the "versions" property from the library. It's probably easier than what we were doing before (parsing each version from an "assets" entry). - for files, we need to invoke the /libraries/:library/:version API instead. However, the default file (which we use for selecting the default checked box in the wizard) is on the library group, not the library-version, so we still need to get that from the first request. - Lastly, I included fields on each API call, so that we're not downloading any data that we aren't intending to use. This drops 10s of KB from most library group queries, since there's a lot of metadata we don't care about. We can always add more back later.
jimmylewis
added a commit
to jimmylewis/LibraryManager
that referenced
this pull request
Jun 28, 2022
This is a port of aspnet#687 to accommodate changes to the "assets" no longer providing data for all versions of a library.
jimmylewis
added a commit
to jimmylewis/LibraryManager
that referenced
this pull request
Jun 28, 2022
This is a port of aspnet#687 to accommodate changes to the "assets" no longer providing data for all versions of a library.
jimmylewis
added a commit
to jimmylewis/LibraryManager
that referenced
this pull request
Jun 28, 2022
This is a port of aspnet#687 to accommodate changes to the "assets" no longer providing data for all versions of a library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cdnjs API is changing to stop including the assets for all versions of a library in the /libraries/:library API. We were using this to determine both library versions and library files.
The changes are fairly straightforward:
Addresses #685 but this will also need to be backported for servicing VS2017 and VS2019.