Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogBox: add aria #3794

Merged
merged 1 commit into from
Oct 11, 2024
Merged

DialogBox: add aria #3794

merged 1 commit into from
Oct 11, 2024

Conversation

DavidFyon
Copy link
Contributor

@DavidFyon DavidFyon commented Oct 10, 2024

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@DavidFyon DavidFyon self-assigned this Oct 10, 2024
Copy link
Contributor

@VachetVirginie VachetVirginie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est normal qu'il n'y ai pas de changement au niveau du snapshot?

@DavidFyon DavidFyon merged commit c526490 into v2-bridge Oct 11, 2024
2 checks passed
@DavidFyon DavidFyon deleted the fix/dialog-box-aria branch October 11, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants