Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectBtnField: fix list padding #3795

Merged
merged 1 commit into from
Oct 11, 2024
Merged

SelectBtnField: fix list padding #3795

merged 1 commit into from
Oct 11, 2024

Conversation

DavidFyon
Copy link
Contributor

@DavidFyon DavidFyon commented Oct 11, 2024

Description

fix selectBtnField padding

Playground

<template>
	<RatingPicker
		v-model="rating"
		label="Êtes-vous satisfait de ce service ?"
		type="emotion"
	>
		<FormField
			v-model="field"
			class="mb-4"
		/>

		<div class="d-flex">
			<VSpacer />

			<VBtn
				right
				color="primary"
			>
				Terminé
			</VBtn>
		</div>
	</RatingPicker>
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	import { Field } from '@cnamts/form-builder/src/components/FormField/types';

	@Component
	export default class RatingPickerEmotion extends Vue {
		rating = -1;

		field: Field = {
			type: 'select',
			title: 'Comment avez-vous connu ce service ?',
			items: [
				{
					text: 'Via une recherche internet',
					value: 'internet'
				},
				{
					text: 'Via un professionnel de santé',
					value: 'professional'
				},
				{
					text: 'Via un ami',
					value: 'friend'
				}
			],
			value: null,
			fieldOptions: {
				type: 'choiceButton',
				label: 'Le moyen par lequel vous avez connu ce service',
				hideDetails: true,
				outlined: true
			}
		};
	}
</script>

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@DavidFyon DavidFyon self-assigned this Oct 11, 2024
@DavidFyon DavidFyon changed the title fix selectBtnField padding SelectBtnField: fix list padding Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d0feb76) to head (cf48e73).
Report is 2 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff            @@
##                v2     #3795   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          249       249           
  Lines         1524      1524           
  Branches       195       195           
=========================================
  Hits          1524      1524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants