DUP: do not generate redundant disconnection triggers #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1015 +/- ##
===============================================
+ Coverage 68.35% 69.60% +1.24%
===============================================
Files 282 264 -18
Lines 7446 7099 -347
===============================================
- Hits 5090 4941 -149
+ Misses 2356 2158 -198 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
In some corner cases, e.g. deletion of a disconnected device, Astarte would generate a disconnection trigger even if the device is already disconnected. Avoid doing so by checking the device connection state before generating a trigger. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
do-not-trigger-disconnection-if-already-disconnected
branch
from
0d4b960
to
3e752a1
Compare
davidebriani
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In some corner cases, e.g. deletion of a disconnected device, Astarte would generate a disconnection trigger even if
the device is already disconnected.
Avoid doing so by checking the device connection state before generating a trigger.
Which issue(s) this PR fixes:
Fixes #1014
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: