Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: remove redundant memory allocation for partial analysis #82

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

CosmoMatt
Copy link
Collaborator

@CosmoMatt CosmoMatt commented Apr 13, 2024

Adds non-intrusive functionality to support future packages:

  • switch for partial analysis transforms to avoid redundant memory

Also fixes a non-failing bug which allocated excess redundant memory in cases where a lower maximum wavelet scale is used in partial analysis transforms.

@CosmoMatt CosmoMatt self-assigned this Apr 13, 2024
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (1ed9009) to head (b50a3e8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   92.00%   92.58%   +0.57%     
==========================================
  Files           7        7              
  Lines         588      580       -8     
==========================================
- Hits          541      537       -4     
+ Misses         47       43       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CosmoMatt CosmoMatt merged commit 5ebccdb into main Apr 13, 2024
3 checks passed
@CosmoMatt CosmoMatt deleted the feature/partial_analysis_switch branch April 13, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant