-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ontology Box init by top left point and bottom right point #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hepengfe
added
topic: ontology
All issues related to ontologies in core, top and base_ontology
topic:cv
labels
Jul 14, 2022
hepengfe
changed the title
Box init
Ontology Box init by top left point and bottom right point
Jul 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
==========================================
+ Coverage 80.78% 80.86% +0.07%
==========================================
Files 254 254
Lines 19401 19434 +33
==========================================
+ Hits 15673 15715 +42
+ Misses 3728 3719 -9
|
mylibrar
reviewed
Jul 14, 2022
mylibrar
reviewed
Jul 15, 2022
Actually, not one of those PR require |
mylibrar
reviewed
Jul 19, 2022
mylibrar
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #878.
Description of changes
Possible influences of this PR.
It can simplify the Box API and enable two ways of initialization.
Test Conducted
Tested wrong box shape and wrong x/y coordinates of top left point and bottom right point.