Performance improvement 904 #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PerformanceImprovement_904 # Conflicts: # forte/data/data_pack.py
…compatibility test)
…ommenting out related code for handling empty sets.
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
=======================================
Coverage 81.00% 81.01%
=======================================
Files 254 254
Lines 19583 19583
=======================================
+ Hits 15864 15865 +1
+ Misses 3719 3718 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sorry the issue link previously was using a wrong URL of my branch. Just changed to the public issue URL of 904. |
I just updated the regular way. |
hunterhector
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #904.
Description of changes
Profiling test find bottleneck in the "get"method of Entry in data_pack.py where using len() causing
slowdown so after discussion this is now fixed using underlying number count.
Possible influences of this PR.
This change can significantly improve the performance and the impact is minimal .
Test Conducted
This should pass all existing unit test code and have good performance on the profiling test.