Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default serialization to the new json method. #918

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

hunterhector
Copy link
Member

@hunterhector hunterhector commented Jan 19, 2023

This PR remove more dependencies to jsonpickle by replacing the default configs to the new json method. This help towards finishing #836

Description of changes

In reader and writer classes, such as those in base_reader.py and writers.py, the default configuration is always jsonpickle or sometimes pickle. In this PR, those are replaced as json.

Possible influences of this PR.

Usage of these methods will actually call the new serialization method now.

Test Conducted

Describe what test cases are included for the PR.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #918 (39e27a2) into master (38c96f5) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   81.06%   81.05%   -0.02%     
==========================================
  Files         256      256              
  Lines       19851    19851              
==========================================
- Hits        16093    16091       -2     
- Misses       3758     3760       +2     
Impacted Files Coverage Δ
forte/data/readers/deserialize_reader.py 64.44% <ø> (ø)
forte/processors/base/writers.py 68.60% <ø> (ø)
forte/processors/writers.py 62.50% <ø> (ø)
tests/forte/data/data_store_serialization_test.py 98.43% <ø> (ø)
tests/forte/data/data_store_test.py 95.58% <ø> (ø)
tests/forte/data/readers/html_reader_test.py 98.76% <ø> (ø)
...atasets/wikipedia/dbpedia/dbpedia_datasets_test.py 100.00% <ø> (ø)
tests/forte/image_annotation_test.py 80.76% <ø> (ø)
...ta_augment/algorithms/data_augmentation_op_test.py 97.71% <ø> (ø)
forte/data/base_reader.py 87.40% <100.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hunterhector hunterhector merged commit 6e2d6ea into asyml:master Jan 19, 2023
@hunterhector hunterhector deleted the serialization_example branch January 19, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant