Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix warnings #1541

Merged
merged 3 commits into from
Oct 3, 2023
Merged

chore: fix warnings #1541

merged 3 commits into from
Oct 3, 2023

Conversation

princerajpoot20
Copy link
Member

@princerajpoot20 princerajpoot20 commented Oct 3, 2023 •
edited
Loading

Related issue(s)

Resolves #1532
Resolves #1533
Resolves #1528

@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 978ce44
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/651bfa849a975e0008149a0f
😎 Deploy Preview https://deploy-preview-1541--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@princerajpoot20 princerajpoot20 changed the title chore: fix sonar warning chore: fix warning Oct 3, 2023
@princerajpoot20 princerajpoot20 changed the title chore: fix warning chore: fix warnings Oct 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6392336365

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 92.231%
Totals Coverage Status
Change from base Build 6392059470: -0.008%
Covered Lines: 5276
Relevant Lines: 5578
💛 - Coveralls

jonaslagoni
jonaslagoni approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@jonaslagoni jonaslagoni merged commit 5c4e362 into asyncapi:master Oct 3, 2023
24 of 25 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @princerajpoot20 for code

@allcontributors allcontributors bot mentioned this pull request Oct 3, 2023
Merged
@allcontributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @princerajpoot20! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
4 participants
@princerajpoot20 @coveralls @jonaslagoni @asyncapi-bot