Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi line descriptions for the pydantic preset in python #1592

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

kennethaasan
Copy link
Collaborator

Description

  • fixes multi-line descriptions for the Pydantic preset in Python

Related issue(s)

Fixes #1058

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 59c11a8
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65437947c0db73000810a1bf
😎 Deploy Preview https://deploy-preview-1592--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some test snapshots updated 🙂

Looks good otherwise 👍

Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6731282431

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.516%

Totals Coverage Status
Change from base Build 6683215025: 0.2%
Covered Lines: 5600
Relevant Lines: 5901

💛 - Coveralls

@kennethaasan
Copy link
Collaborator Author

Need some test snapshots updated 🙂

Looks good otherwise 👍

Ups, updated now 😄

@jonaslagoni jonaslagoni changed the title fix: fixes multi line descriptions for the pydantic preset in python fix: multi line descriptions for the pydantic preset in python Nov 2, 2023
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jonaslagoni
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 2c46b94 into asyncapi:master Nov 2, 2023
19 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Pydantic improvements
4 participants