fix!: add csharp support for DateTime, TimeSpan, Guid #1612
Conversation
jano-petras
requested review from
magicmatatjahu,
jonaslagoni,
kennethaasan and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for modelina canceled.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
jano-petras
changed the title
jano-petras
changed the title
jonaslagoni
changed the title
There was a problem hiding this comment.
Nice @jano-petras!
Just need to run npm run lint:fix and add a small section in the migration docs about this breaking change for the C# models: https://github.com/asyncapi/modelina/blob/next/docs/migrations/version-2-to-3.md
Everything else is good 👌
|
SonarCloud Quality Gate failed.
|
|
Thanks @jonaslagoni, that has been addressed now |
|
/rtm |
|
🎉 This PR is included in version 3.0.0-next.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @jano-petras for code, docs, test |
|
I've put up a pull request to add @jano-petras! 🎉 |
* feat!: convert to use multi parser (#1587) * feat!: adds support for duration in java (#1604) * feat: enable AsyncAPI v3 (#1600) * fix!: add csharp support for DateTime, TimeSpan, Guid (#1612) * feat!: adds extend in common, meta, and constrained models (#1613) * feat!: adds inheritance with interfaces for java (#1593) * chore: remove duplicate version entry for AsyncAPI processor (#1609) * feat!: render python union in pydantic in the pre 3.10 way (#1626) * feat: add file path as input (#1601) * feat!: add options as parameter to constraints (#1667) * fix: (un)marshalling tuple and dictionary unwrapping for Typescript (#1717) * fix: jsonbinpack preset and runtime tests (#1718) * chore: fix linting * chore: remove unused directory * feat!: add useJavascriptReservedKeywords option for TS (#1727) * feat: enable raw properties for interface (#1729) * fix: newtonsoft could not handle enum values (#1731) * chore: update Java runtime tests (#1739) * fix: edge case where references was incorrect handled for JSON Schema (#1754) * fix: recursion bug for get nearest dependencies (#1757) --------- Co-authored-by: Kenneth Aasan <k.aasan@sportradar.com> Co-authored-by: jano-petras <jano.petras@gmail.com> Co-authored-by: Nilkanth Parmar <parmarnilkanth@gmail.com>
|
🎉 This PR is included in version 4.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Extending supported string formats for C#:
Added relevant tests and extended existing examples where relevant
Related issue(s)
Resolves #1607