Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(website): rewrite class-based react components to functional components in modelina website #1649

Closed
wants to merge 0 commits into from

Conversation

devilkiller-ag
Copy link
Member

Description
The current codebase of the Playground Generator Options, Docs, and Examples Components of the Modelina Website contained class-based react components. I have updated the code base to use functional components and hooks at all places. This results in cleaner, easier-to-understand components compared to class components.

Related issue(s)
Fixes #1648

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 95c1e93
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6579efd393208600088235b6

@devilkiller-ag devilkiller-ag changed the title Rewrite Class-Based React Components to Functional Components in Modelina Website chore(website): rewrite class-based react components to functional components in modelina website Dec 12, 2023
@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7190113857

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.516%

Totals Coverage Status
Change from base Build 7162842882: 0.0%
Covered Lines: 5600
Relevant Lines: 5901

💛 - Coveralls

@devilkiller-ag devilkiller-ag changed the title chore(website): rewrite class-based react components to functional components in modelina website refactor(website): rewrite class-based react components to functional components in modelina website Dec 12, 2023
@devilkiller-ag devilkiller-ag marked this pull request as draft December 12, 2023 11:49
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devilkiller-ag
Copy link
Member Author

Hi @jonaslagoni, It was due to different types of query values for different options, I have resolved it.

@devilkiller-ag devilkiller-ag marked this pull request as ready for review December 13, 2023 02:53
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@devilkiller-ag
Copy link
Member Author

Hi @jonaslagoni, It seems the pull bot forcely pushed the master branch to my branch and all changes made by me are gone. Due to this I also can't see the review you requested. Can you suggest why this happened and what changes you requested?

@jonaslagoni
Copy link
Member

@devilkiller-ag ehh, I have not seen this before? 🧐

@jonaslagoni
Copy link
Member

Can you re-create the branch and the changes? 🤔

@devilkiller-ag
Copy link
Member Author

Yeah Sure, but it just scared me 💀😂

@devilkiller-ag
Copy link
Member Author

@jonaslagoni I created a new PR from new branch: #1655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Class-Based React Components to Functional Components in Modelina Website
3 participants