-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(website): rewrite class-based react components to functional components in modelina website #1649
Conversation
✅ Deploy Preview for modelina canceled.
|
Pull Request Test Coverage Report for Build 7190113857
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got a build error 🙂 https://app.netlify.com/sites/modelina/deploys/6577f46ad08e2b00086338de
Hi @jonaslagoni, It was due to different types of query values for different options, I have resolved it. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Hi @jonaslagoni, It seems the pull bot forcely pushed the master branch to my branch and all changes made by me are gone. Due to this I also can't see the review you requested. Can you suggest why this happened and what changes you requested? |
@devilkiller-ag ehh, I have not seen this before? 🧐 |
Can you re-create the branch and the changes? 🤔 |
Yeah Sure, but it just scared me 💀😂 |
@jonaslagoni I created a new PR from new branch: #1655 |
Description
The current codebase of the Playground Generator Options, Docs, and Examples Components of the Modelina Website contained class-based react components. I have updated the code base to use functional components and hooks at all places. This results in cleaner, easier-to-understand components compared to class components.
Related issue(s)
Fixes #1648