-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: handle edge case in toCamelCase FormatHelper #1792
Conversation
✅ Deploy Preview for modelina canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@moritzkalwa this is gonna be a breaking change, let me setup the |
I am targeting the next branch already though 🤔 |
It is currently in an old state, updating it with #1795 then we can merge yours ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding a v3-v4 migration document and adding the camel case changes that break existing models?
Nope, all for it! Gonna try to get that done today :) |
|
@jonaslagoni I added a migration guide. Hope that does it, most users should not encounter any issues anyway since this should be fairly rare and if they do all they can do is check for properties that were renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are changing how camelCase
works for all it's a more generic migration guide, so did some small changes ✌️
Other then that it looks good 💪
Quality Gate passedIssues Measures |
/rtm |
🎉 This PR is included in version 4.0.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @moritzkalwa for code, test, bug, docs |
I've put up a pull request to add @moritzkalwa! 🎉 |
Description
The
toCamelCase
helper produced wrong outputs in some edge cases, where there was a numeric followed by "_" and a lowercase letter. This PR aims to fix that.Related Issue
Fixes #1503
Checklist
npm run lint
).npm run test
).