Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added loading text #2132

Merged
merged 3 commits into from
Dec 2, 2024
Merged

feat: added loading text #2132

merged 3 commits into from
Dec 2, 2024

Conversation

Shriya-Chauhan
Copy link
Contributor

@Shriya-Chauhan Shriya-Chauhan commented Nov 30, 2024

Description

Added loader.

Screencast.from.11-30-2024.08.11.34.PM.webm

Related Issue

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 97b9a5f
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/674c42cbd3d6750008afcae1
😎 Deploy Preview https://deploy-preview-2132--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shriya-Chauhan
Copy link
Contributor Author

@devilkiller-ag I have created pr for resolving issue #1725 . Please take a look and let me know if any changes required.

@Shriya-Chauhan Shriya-Chauhan changed the title Fix #1725: Added loading text fix: Added loading text Nov 30, 2024
@Shriya-Chauhan Shriya-Chauhan changed the title fix: Added loading text fix: added loading text Nov 30, 2024
@coveralls
Copy link

coveralls commented Nov 30, 2024

Pull Request Test Coverage Report for Build 12104858934

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.314%

Totals Coverage Status
Change from base Build 12027877094: 0.0%
Covered Lines: 6002
Relevant Lines: 6333

💛 - Coveralls

@Shriya-Chauhan Shriya-Chauhan changed the title fix: added loading text feat: added loading text Dec 1, 2024
Copy link

sonarqubecloud bot commented Dec 1, 2024

Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shriya-Chauhan All changes looks good to me! Thanks for contributing, feel free to solve more issues.

@devilkiller-ag
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit b7f45a6 into asyncapi:master Dec 2, 2024
16 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Shriya-Chauhan
Copy link
Contributor Author

@devilkiller-ag Thank you for your support and guidance. I would love to contribute more—kindly point me to any other issues where I can help.

@devilkiller-ag
Copy link
Member

@devilkiller-ag Thank you for your support and guidance. I would love to contribute more—kindly point me to any other issues where I can help.

You can try #1360. Besides this, we have also some issues related to Modelina tool which you can explore on the issues page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants