Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTA for ESPHome 2024.6 #65

Merged
merged 28 commits into from
Jun 21, 2024
Merged

Fix OTA for ESPHome 2024.6 #65

merged 28 commits into from
Jun 21, 2024

Conversation

dexn
Copy link

@dexn dexn commented Jun 20, 2024

  • Changed all project versions to follow the three-part version numbering and incremented by 0.0.1
  • Added ESPHome "min_version" to all and adjusted existing to "2024.6.0"
  • Added ota "platform" to all (required from ESPHome 2024.6.0)
  • Removed some extra empty lines to clean up

@tarontop tarontop merged commit db0a0da into athom-tech:main Jun 21, 2024
21 of 24 checks passed
@falconindy
Copy link

I appreciate the fix here, but without an 'id' for the new section, it's impossible for consumers to !extend the config to add trivial things like a password. See esphome/issues#5952 for the "failure" mode.

@jonfranz24
Copy link

Is there any updates related to @falconindy comment above , and getting this issue resolved?

@Roving-Ronin
Copy link

@dexn I assume you have some method to go through all the Athom (on this and the ESP32 repo) to make a change that applies to all of them (i.e. so editing every file individually is not required) ?
If so, could you assist with how to do this for all files, changing the following substitutions line in all the yamls?

From:

  dns_domain: ""

To:

  dns_domain: ".local"

#111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants