Skip to content

Commit

Permalink
Input: atmel_mxt_ts - Only warn when config CRC does not match
Browse files Browse the repository at this point in the history
The CRC will not match if the config has been upgraded (ie the info_crc
doesn't match), also there are new chips with objects included in the CRC
which are previous to T7, and some chips without T7, which means that this
code must only produce a warning until those issues are dealt with.

Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
Signed-off-by: Atul Tiwari <atul.tiwari@atmel.com>
  • Loading branch information
ndyer committed May 24, 2013
1 parent c48e916 commit d8d3982
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/input/touchscreen/atmel_mxt_ts.c
Original file line number Diff line number Diff line change
Expand Up @@ -1566,13 +1566,10 @@ static int mxt_check_reg_init(struct mxt_data *data)
data->T7_address - cfg_start_ofs,
config_mem_size);

/* check the crc, calculated should same as what's in file */
if (config_crc > 0 && (config_crc != calculated_crc)) {
dev_err(dev, "CRC mismatch in config file, calculated=%06X, file=%06X\n",
/* Check the crc, calculated should match what is in file */
if (config_crc > 0 && (config_crc != calculated_crc))
dev_warn(dev, "CRC mismatch in config file, calculated=%06X, file=%06X\n",
calculated_crc, config_crc);
ret = 0;
goto release_mem;
}

/* Write configuration as blocks */
byte_offset = 0;
Expand Down

0 comments on commit d8d3982

Please sign in to comment.