Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Oliver,
I followed the "How to contribute guidelines". This is a fully working py-metmm setup using the pyarts. All sensors setups run without problems.
Several issues that I know of:
robust=1
inybatchCalc
, because I got the following run-time error for Garand atmospheres index: 16,17 and 21origin/master
branch results in the deltas of -30 to 60K compared with "ybatchREFERENCE.xml". Also, the TestMetMM incontrolfiles/instruments/metmm
fails with similarly big differences.remotes/origin/v2.4.x
andremotes/origin/before-newlinerecord
.One note to the "How to commit" documentation. I didn't understand the section Update your working copy, and what the
upstream
andrebase
actually do, e.g. in this codegit pull --rebase upstream master
.I have a separate github repository for py-metmm setup. I created it if I need to imporove the metmm code a bit more.
https://github.com/obobryshev/py_metmm
MetMM setup relies on the extract of HITRAN2012 with the changed line parameters for WV line at 183.31 GHz:
controlfiles/instruments/metmm/abs_lines_metmm.xml.gz
Both metmm versions rely on this file. Is it ok to rely on this file for both versions for now? In the end I plan to read the HITRAN catalogue and change this one line parameters on-the-fly using the functionabs_linesReplaceWithLines
. This is an open todo.Kind regards,
Alex