Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Hop 2.x api updates (2.5.0-SNAPSHOT) #11

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Conversation

bamaer
Copy link
Contributor

@bamaer bamaer commented Apr 1, 2023

🤸 Please for non-trivial changes, fill a GitHub issue and set the PR title like Issues #XXX, #YYY, #ZZZ. Trivial changes are typo, documentation, example...

☑ Checklist

  • I've compiled and checked the changes with mvn clean verify
  • I tested my changes and added relevant example if possible
  • I updated documentation if needed
  • Each commit has a meaningful subject line and body
  • The pull request addresses just the described changes
  • I assume that the licenses are respected
  • I self-reviewed my own code

𝌡 Proposed changes

Please explain your changes here so that anyone can understand what it does, how, and why.

Fixes: updates to work with Apache Hop 2.x api

  • #XXX
  • #YYY

Types of changes:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

GIS Transforms concerned:

  • Coordinate system operation
  • GIS File input
  • GIS File output
  • Geometry information
  • Geoprocessing
  • Geospatial Group by
  • Spatial relationship and proximity

🏭 How to test the changes?

Please describe how you tested the changes so that we can we can reproduce.

For example, you can add a transformation or a pipeline in the examples directory and the datasets or how to get them.

Only very basic tests: verified all transforms are available in the context dialog, can be added to a pipeline and the dialog can be opened.

🙏 Thank you! 🙏

@cvagner cvagner merged commit f8fba84 into atolcd:master Oct 22, 2023
1 check passed
@cvagner
Copy link
Member

cvagner commented Oct 23, 2023

Thanks a lot @bamaer !!

We tested your work with Hop 2.6.0 with the 2 pipelines which are in the examples directory of the repo.
It's workd great with the standalone version and with the dockerized version built with docker/hop-gis/Dockerfile with a little adjustment on the last one (it seems tha DEPLOYMENT_PATH has lost a level "hop" directory).

Thanks to you work, plugins are now compatibles with Hop 2.6.0 et 2.7.0-SNAPSHOT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants