Update PR comments

R/meta_utils.R

@@ -160,7 +160,7 @@ get_meta_subset.data.frame <- function(x, row_id, column,
  }
 
  if (length(list(...)) > 0) {
- warning("Extra arguments were provided to get_meta_subset() that will not be used.")
+ warning("Extra arguments were provided to get_meta_subset() that will not be used.", immediate.=TRUE)
  }
 
  out <- target %>%
@@ -195,33 +195,7 @@ get_meta_subset.tplyr_table <- function(x, row_id, column, add_cols = vars(USUBJ
  # Get the metadata object ready
  m <- get_meta_result(x, row_id, column)
 
- # if (!inherits(add_cols, 'quosures')) {
- # stop("add_cols must be provided using `dplyr::vars()`", call.=FALSE)
- # }
- #
- # if (length(list(...)) > 0) {
- # warning("Extra arguments were provided to get_meta_subset() that will not be used.")
- # }
-
  get_meta_subset(x$metadata, row_id, column, add_cols = add_cols,
  target = x$target, pop_data = x$pop_data)
- # # Subset and return the data
- # out <- x$target %>%
- # filter(!!!m$filters) %>%
- # select(!!!add_cols, !!!m$names)
- #
- # if (!is.null(m$anti_join)) {
- # aj <- m$anti_join
- # pd <- X$pop_data %>%
- # filter(!!!aj$join_meta$filters) %>%
- # select(!!!aj$on, !!!add_cols, !!!aj$join_meta$names)
- #
- # mrg_var <- map_chr(aj$on, as_name)
- # names(mrg_var) <- mrg_var
- #
- # out <- anti_join(pd, out, by=mrg_var)
- # }
- #
- # out
 }