Skip to content

Commit

Permalink
PR review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
mstackhouse committed Feb 13, 2024
1 parent 8d70c50 commit b261356
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
1 change: 0 additions & 1 deletion R/count.R
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ process_summaries.count_layer <- function(x, ...) {

process_count_denoms(x)

outer <- FALSE
process_single_count_target(x)

}
Expand Down
16 changes: 0 additions & 16 deletions R/desc.R
Original file line number Diff line number Diff line change
Expand Up @@ -59,22 +59,6 @@ process_summaries.desc_layer <- function(x, ...) {
ungroup()

num_sums_raw[[i]] <- complete_and_limit(cmplt1, treat_var, by, cols, limit_data_by=limit_data_by)
# num_sums_raw[[i]] <- cmplt1 %>%
# # complete all combinations of factors to include combinations that don't exist.
# # add 0 for combinations that don't exist
# complete(!!treat_var, !!!by, !!!cols)
#
# # Apply data limits specified by setter
# if (exists("limit_data_by")) {
# # Find the combinations actually in the data
# groups_in_data <- cmplt1 %>%
# distinct(!!!limit_data_by)
#
# # Join back to limit the completed levels based on the preferred
# # data driven ones
# num_sums_raw[[i]] <- groups_in_data %>%
# left_join(num_sums_raw[[i]], by = map_chr(limit_data_by, as_name))
# }

# Create the transposed summary data to prepare for formatting
trans_sums[[i]] <- num_sums_raw[[i]] %>%
Expand Down

0 comments on commit b261356

Please sign in to comment.