Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can be merged now. #163

Merged
merged 2 commits into from
Dec 18, 2023
Merged

I can be merged now. #163

merged 2 commits into from
Dec 18, 2023

Conversation

mstackhouse
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f26ff6) 92.52% compared to head (5e5d244) 92.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #163   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          43       43           
  Lines        2784     2784           
=======================================
  Hits         2576     2576           
  Misses        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ShiyuC ShiyuC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just had super minor suggestions on the alignment of the tibbles

R/collapse_row_labels.R Outdated Show resolved Hide resolved
tests/testthat/test-collapse_row_labels.R Outdated Show resolved Hide resolved
mstackhouse and others added 2 commits December 18, 2023 08:35
Co-authored-by: Shiyu Chen <39443807+ShiyuC@users.noreply.github.com>
Co-authored-by: Shiyu Chen <39443807+ShiyuC@users.noreply.github.com>
@mstackhouse mstackhouse changed the base branch from main to devel December 18, 2023 13:35
@mstackhouse mstackhouse changed the title DON'T MERGE ME I can be merged now. Dec 18, 2023
@mstackhouse mstackhouse merged commit 9a17f5c into devel Dec 18, 2023
7 checks passed
@mstackhouse mstackhouse linked an issue Dec 18, 2023 that may be closed by this pull request
6 tasks
@mstackhouse mstackhouse deleted the gh_issue_129 branch December 19, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse row labels into one column
3 participants