Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move data from vignettes to package data #164

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Move data from vignettes to package data #164

merged 7 commits into from
Dec 18, 2023

Conversation

asbates
Copy link
Collaborator

@asbates asbates commented Dec 15, 2023

  • Moves the data sets in the /vignettes directory to /data-raw and include them in the package.
  • Documents the data sets, but instead of writing out 200+column descriptions, adds a helper function get_dataset_labels
  • Data sets in the /tests folder were left as is because there are some differences between these and the ones that were in vignettes.

closes #62

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mstackhouse
Copy link
Contributor

@asbates for all the data, can we update it so each dataset is prefixed with tplyr_? So for example, it would be tplyr_adae, tplyr_adsl, tplyr_adlb, etc.

The reason for this is that the datasets are likely named adae, adsl, adlb within the user's sessions when they're programming. So you don't want a dataset to be found in the namespace search.

@mstackhouse
Copy link
Contributor

@asbates I tested out the pkgdown build and verified the site - found some changes that had to be made so I cleaned that up and updated the pkgdown yaml file. So once the checks all pass we should be good here.

@mstackhouse mstackhouse merged commit 5e1dcf2 into devel Dec 18, 2023
4 checks passed
@mstackhouse mstackhouse deleted the gh_issue_62 branch December 19, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants