Resolve #83, #84, #173 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'gh_issue_84' into gh_issue_83 # Conflicts: # R/nested.R # R/sort.R # R/zzz.R
asbates
requested changes
Feb 12, 2024
vignettes/denom.Rmd
Outdated
| kable() | ||
| ``` | ||
|
|
||
| In the example above, we produce a nested count layer. Using the function `add_missing_subjects_row()`. This triggers the addition of the new result row for which the missing subjects are calculated. The row label applied for this can be configured using `set_missing_subjects_row_label()`, and the row label itself will default for Missing. Depending on your sorting needs, a `sort_value` can be applied to whatever numeric value you provide. Lastly, you can provide an `f_str()` to format the missing subjects row separately from the rest of the layer, but whatever format is applied to the layer will apply otherwise. |
There was a problem hiding this comment.
... nested count layer. The function add_missing_subjects_row() triggers the addition ...
... default for Missing. -> ... default to 'Missing.'
There was a problem hiding this comment.
Ok that's updated.
asbates
approved these changes
Feb 12, 2024
elimillera
reviewed
Feb 13, 2024
elimillera
approved these changes
Feb 13, 2024
This was referenced Feb 14, 2024
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
This PR adds the new function
set_limit_data_by()to address #84. Along the way, a pre-existing bug (#173) was found and this PR resolves that issue as well and adds tests to catch it in the future.The last push also includes updates for #83. Note there are a few warnings coming out of
test-count.R, but those should be resolved by #167 which removes the chunk of code from which is warnings are emanating.