Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub issue #3, #16, #17, #18, #20 #19

Merged
merged 12 commits into from
Sep 29, 2023
Merged

GitHub issue #3, #16, #17, #18, #20 #19

merged 12 commits into from
Sep 29, 2023

Conversation

mstackhouse
Copy link
Contributor

@mstackhouse mstackhouse commented Sep 20, 2023 •
edited
Loading

Closes #3, #16, #17, #18, #20

  • Documentation is updated to reflect changes
  • Unit tests are updated and code coverage is kept at 100%
  • Tested with back-versioned imports
  • Documentation rebuilt
  • R CMD Check passing

@mstackhouse mstackhouse changed the base branch from main to dev September 20, 2023 16:01
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@0b85259). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head df5bda0 differs from pull request most recent head 3a04e48. Consider uploading reports for the commit 3a04e48 to get more accurate results

@@           Coverage Diff           @@
##             dev       #19   +/-   ##
=======================================
  Coverage       ?   100.00%           
=======================================
  Files          ?         9           
  Lines          ?       252           
  Branches       ?         0           
=======================================
  Hits           ?       252           
  Misses         ?         0           
  Partials       ?         0

@mstackhouse mstackhouse mentioned this pull request Sep 20, 2023
Closed
@mstackhouse mstackhouse changed the title GitHub issue #3, #16 GitHub issue #3, #16, #18, #20 Sep 20, 2023
@mstackhouse mstackhouse changed the title GitHub issue #3, #16, #18, #20 GitHub issue #3, #16, #17, #18, #20 Sep 20, 2023
nicholas-masel
nicholas-masel reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@nicholas-masel nicholas-masel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just another minor comment about a comment

R/write_dataset_json.R Outdated Show resolved Hide resolved
mstackhouse and others added 2 commits September 29, 2023 13:46
@mstackhouse @nicholas-masel
Update R/write_dataset_json.R
533c66f 
Co-authored-by: Nicholas Masel <61123199+nicholas-masel@users.noreply.github.com>
@mstackhouse
Resolve merge conflicts and update NEWS
3a04e48 
Merge branch 'dev' of github.com:atorus-research/datasetjson into github_issue_3_16

# Conflicts:
#	R/utils.R
#	tests/testthat/test-utils.R
@mstackhouse mstackhouse merged commit ca1e0ab into dev Sep 29, 2023
@mstackhouse mstackhouse deleted the github_issue_3_16 branch December 19, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-masel nicholas-masel nicholas-masel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstackhouse @nicholas-masel