Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh issue 43 #45

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Gh issue 43 #45

merged 6 commits into from
Sep 5, 2024

Conversation

mstackhouse
Copy link
Contributor

Updates for 1.1.0 Schema on file level metadata

@mstackhouse mstackhouse changed the base branch from main to dev September 5, 2024 19:24
R/datasetjson.R Outdated Show resolved Hide resolved
Co-authored-by: Nicholas Masel <61123199+nicholas-masel@users.noreply.github.com>
@mstackhouse mstackhouse merged commit 2dc4c43 into dev Sep 5, 2024
0 of 4 checks passed
#' @family File Metadata Setters
#' @rdname file_metadata_setters
#' @family Dataset Metadata Setters
#' @rdname dataset_metadata_setters
set_originator <- function(x, originator) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a generic setter function? Or keep this as one setter per?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they're 90% one liner attribute setters I didn't bother abstracting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants